fix: warn user when filament serial input sanitizes to empty string#10879
Open
BenJule wants to merge 1 commit into
Open
fix: warn user when filament serial input sanitizes to empty string#10879BenJule wants to merge 1 commit into
BenJule wants to merge 1 commit into
Conversation
BambulabRobot
requested review from
ShanCang-BamBu,
XunZhangBambu and
tonghao-bbl
Contributor
Author
|
Apologies — this PR was closed by mistake on 2026-06-07, and that was an error on my side, not a deliberate decision to withdraw the change. It happened as an unintended side effect of a branch cleanup in my fork: deleting the head branch automatically closed this PR. The contribution still stands. I have restored the branch and reopened the PR. Sorry for the noise and any confusion this caused. |
tonghao-bbl
reviewed
Jun 17, 2026
tonghao-bbl
left a comment
tonghao-bbl
left a comment
Contributor
There was a problem hiding this comment.
Hi @BenJule Can you have a look at these small issues in the comment?
| } | ||
| boost::algorithm::trim(vendor_name); | ||
| boost::algorithm::trim(serial_name); | ||
| if (!serial_str.IsEmpty() && serial_name.empty()) { |
Contributor
There was a problem hiding this comment.
!serial_str.IsEmpty()is not needed here, check line 1022or leave it blank.in the message dilaog is not OK here since we dont accpet empty string as checked above
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
src/slic3r/GUI/CreatePresetsDialog.cpp: Add validation that warns the user when serial input becomes empty after sanitizationTest plan